Skip to content

Conversation

@oto-ciulis-tt
Copy link
Contributor

image

Copy link
Member

@robinjhuang robinjhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the text to "Automatically send crash reports"?

Also, the first time the app starts up the comfy.settings.json file may not exist and this choice will be removed. We should apply this change after the launchPythonServer has returned.

Also, we don't want to overwrite the entire file since it may be edited elsewhere (by the ComfyUI python server). We should just only change the single field.

@robinjhuang
Copy link
Member

Closes #167

@oto-ciulis-tt oto-ciulis-tt merged commit bcf2877 into main Nov 8, 2024
6 checks passed
@oto-ciulis-tt oto-ciulis-tt deleted the enh/Ask-user--Capture-error-in-Sentry-when-app-crashes branch November 8, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants